Page MenuHomeFreeBSD
Differential D19210

misc/xiphos: Unbreak build
ClosedPublic
Actions

Authored by kai on Feb 16 2019, 12:29 PM.
Tags
None
Referenced Files
F162701753: D19210.id54054.diff
Wed, Jul 15, 10:48 PM
Unknown Object (File)
Mon, Jul 13, 1:37 PM
Unknown Object (File)
Mon, Jul 13, 8:00 AM
Unknown Object (File)
Sun, Jul 12, 10:37 AM
Unknown Object (File)
Sat, Jul 4, 7:24 AM
Unknown Object (File)
Fri, Jul 3, 8:34 PM
Unknown Object (File)
Fri, Jul 3, 12:51 AM
Unknown Object (File)
Mon, Jun 29, 4:49 PM
View All Files
Subscribers
None

Details

Reviewers
miwi
tcberner
joneum
Commits
rP493472: misc/xiphos: Unbreak build
Summary

PR 232997

  • Unbreak build by adding "-ftemplate-depth=1024" to CXXFLAGS
  • Add missing libraries

While I'm here:

  • Fix license and add path to license file
  • Add "gnome" to USES because using USE_GNOME alone is deprecated
  • Pet portlint
Test Plan
  • poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r342772 amd64 + i386) -> OK
  • portlint -> OK (just warns about the BUILD_DEPENDS=${RUN_DEPENDS} [...] construct)
  • Runtime tests -> OK

It builds also fine on the 2019Q1 branch for the case if a MFH is required/accepted.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kai created this revision.Feb 16 2019, 12:29 PM
Harbormaster completed remote builds in B22525: Diff 53986.Feb 16 2019, 12:29 PM
tcberner added inline comments.Feb 18 2019, 6:54 PM
misc/xiphos/Makefile
33 ↗(On Diff #53986)

there should be no need for ".

kai updated this revision to Diff 54054.Feb 18 2019, 11:47 PM
  • Removed double-quotes from the CXXFLAGS value
Harbormaster completed remote builds in B22563: Diff 54054.Feb 18 2019, 11:47 PM
kai marked an inline comment as done.Feb 18 2019, 11:48 PM
kai added inline comments.
misc/xiphos/Makefile
33 ↗(On Diff #53986)

Ok, the double-quotes are removed.

miwi accepted this revision.Feb 19 2019, 1:44 PM

LGTM

This revision is now accepted and ready to land.Feb 19 2019, 1:44 PM
Closed by commit rP493472: misc/xiphos: Unbreak build (authored by kai). · Explain WhyFeb 20 2019, 10:11 PM
This revision was automatically updated to reflect the committed changes.
kai marked an inline comment as done.

Revision Contents
Changeset List

PathSize
head/
misc/
xiphos/
20 lines

Diff 54158

View Options

head/misc/xiphos/Makefile

Loading...