Page MenuHomeFreeBSD

Mk/bsd.options.mk: Add opt_MESON_ENABLE options helper
AbandonedPublic

Authored by tobik on Tue, Feb 5, 11:59 AM.

Details

Reviewers
None
Group Reviewers
gnome
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Some newer ports using Meson now pass -Dopt=enabled or -Dopt=disabled
to it. Maybe we should add an options helper for this now.

I converted x11/swaylock as an example.

This is for Meson's new feature build options which are available since 0.47.0.

https://mesonbuild.com/Release-notes-for-0-47-0.html#new-type-of-build-option-for-features
https://mesonbuild.com/Build-options.html#features

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22352
Build 21527: arc lint + arc unit

Event Timeline

tobik created this revision.Tue, Feb 5, 11:59 AM
tobik edited the summary of this revision. (Show Details)Tue, Feb 5, 12:04 PM
mat added a comment.Tue, Feb 5, 1:52 PM

Using the *_MESON_TRUE is not possible ?

Also, you probably will need a *_MESON_DISABLE. (doing what the _FALSE does for the _TRUE.)

tobik added a comment.Tue, Feb 5, 2:14 PM
In D19085#408107, @mat wrote:

Using the *_MESON_TRUE is not possible ?

No. Here's what happens in x11/swaylock if using *_MESON_TRUE instead of *_MESON_ENABLE:

meson.build:1:0: ERROR:  Value "true" for combo option "man-pages" is not one of the choices. Possible choices are: "enabled", "disabled", "auto".

Also, you probably will need a *_MESON_DISABLE. (doing what the _FALSE does for the _TRUE.)

Do we? I cannot find a single port even using *_MESON_FALSE. Same for *_MESON_NO. We also don't have a *_CONFIGURE_DISABLE or *_CONFIGURE_WITHOUT (though there are several ports pretending those exist...).

tobik updated this revision to Diff 53602.Tue, Feb 5, 3:58 PM
  • Add opt_MESON_DISABLE too
mat added a comment.Wed, Feb 6, 9:12 AM

Do we? I cannot find a single port even using *_MESON_FALSE. Same for *_MESON_NO.

Maybe we don't, I don't know, I just try to cover all bases. If we don't, then we don't :-)

tobik abandoned this revision.Fri, Feb 8, 10:12 PM

Abandoning in favor of D19127...