Page MenuHomeFreeBSD

[NEW PORT]: net/v2ray: Platform for building proxies to bypass network restrictions
ClosedPublic

Authored by loader on Feb 2 2019, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 18, 8:18 AM
Unknown Object (File)
Dec 24 2023, 6:48 AM
Unknown Object (File)
Dec 24 2023, 6:48 AM
Unknown Object (File)
Dec 24 2023, 6:43 AM
Unknown Object (File)
Dec 24 2023, 6:43 AM
Unknown Object (File)
Dec 24 2023, 3:39 AM
Unknown Object (File)
Dec 21 2023, 10:52 PM
Unknown Object (File)
Dec 20 2023, 1:30 AM
Subscribers

Details

Summary

Proposed commit log message:

[NEW PORT]: net/v2ray: Platform for building proxies to bypass network restrictions

Project V is a set of network tools that help you to build your
own computer network. It secures your network connections and
thus protects your privacy.

WWW: https://www.v2ray.com

PR: 235418
Submitted by: Yanhui Shen <shen.elf@gmail.com>
Reviewed_by: koobs, mat
Approved by: koobs (mentor)
Differential_Revision: D19066
Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere: 1300008, amd64, '', tested)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

net/v2ray/Makefile
8 ↗(On Diff #53545)

As the distname is not versionned, you should add the port version to this.

19 ↗(On Diff #53545)

WRKSRC_SUBDIR.

loader edited the summary of this revision. (Show Details)

DIST_SUBDIR= ${PORTNAME}-${PORTVERSION}

loader added inline comments.
net/v2ray/Makefile
8 ↗(On Diff #53545)

Thanks @mat.

19 ↗(On Diff #53545)

This one was trying to set ${EXTRACT_WRKDIR} to ${WRKDIR}/src

The default GOPATH is ${WRKDIR} in ${GO_ENV}:
https://svnweb.freebsd.org/ports/head/Mk/Uses/go.mk?revision=478076&view=markup#l61

61      GO_ENV+=        GOPATH="${WRKDIR}:${LOCAL_GOPATH}" \
62                      CGO_CFLAGS="${CGO_CFLAGS}" \
63                      CGO_LDFLAGS="${CGO_LDFLAGS}" \
64                      GOBIN=""

Go loads the packages from GOPATH/src (https://github.com/golang/go/wiki/GOPATH):

# make 
===>  Building for v2ray-4.14.0
can't load package: package v2ray.com/core/main: cannot find package "v2ray.com/core/main" in any of:
        /usr/local/go/src/v2ray.com/core/main (from $GOROOT)
        /usr/ports/net/v2ray/work/src/v2ray.com/core/main (from $GOPATH)
        /usr/local/share/go/src/v2ray.com/core/main
*** Error code 1
This revision is now accepted and ready to land.May 7 2019, 4:51 AM
This revision was automatically updated to reflect the committed changes.
head/net/v2ray/Makefile
20

Why +=?

26–32

This should be in a pkg-plist file.