Differential D19051

else
ClosedPublic
Actions

Authored by freqlabs on Feb 1 2019, 2:49 AM.

Tags

None

Referenced Files

	F153549482: D19051.diff
	Tue, Apr 21, 8:10 PM

	Unknown Object (File)
	Mon, Apr 20, 2:01 PM

	Unknown Object (File)
	Sun, Apr 19, 12:53 PM

	Unknown Object (File)
	Sun, Apr 19, 12:54 AM

	Unknown Object (File)
	Sat, Apr 18, 10:37 PM

	Unknown Object (File)
	Sat, Apr 18, 9:50 AM

	Unknown Object (File)
	Sat, Apr 18, 9:02 AM

	Unknown Object (File)
	Fri, Apr 17, 2:01 PM

View All Files

Subscribers

imp

Details

Reviewers

mav

Commits

rS343727: Use switch instead of chained if/else to improve readability.

Summary

Using a switch statement helps improve readability.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freqlabs created this revision.Feb 1 2019, 2:49 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2019, 2:49 AM

Looks good to me.

This revision is now accepted and ready to land.Feb 1 2019, 3:50 AM

Closed by commit rS343727: Use switch instead of chained if/else to improve readability. (authored by mav). · Explain WhyFeb 4 2019, 1:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

cam/

scsi/

scsi_enc_ses.c

22 lines

Diff 53569

View Options

head/sys/cam/scsi/scsi_enc_ses.c

cam/scsi: Use switch instead of chained if/elseClosedPublicActions