Page MenuHomeFreeBSD

sysutils/node_exporter: Add license file, tests, docs and examples
Needs ReviewPublic

Authored by 0mp on Wed, Jan 9, 3:48 PM.

Details

Reviewers
mat
krion
Summary
sysutils/node_exporter: Add tests, docs and examples

- Define LICENSE_FILE.
- Sort variables.
- Add a do-test target and prepare a testing environment.  One test is skipped
  at the moment due to a problem with detecting procfs(5) on FreeBSD.
- Install documentation and examples.
- Change pkg-descr to better match upstream's README.

I am not sure about a couple of things, however:

  • Is it fine to use USES=gmake instead of TEST_DEPENDS=gmake:devel/gmake? USES=gmake adds a dependency to the build process, which is not ideal.
  • The whole pre-test target is rather hacky. I was unable to come up with a prettier solution though. Go is a little bit hard to tame.

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234791

Test Plan
  • portlint
  • poudriere testport:
    • 11.2 & 12.0 on amd64 & i386

In order to try out the test suite:

sh
echo "cd /usr/ports/sysutils/node_exporter/ && make test" | poudriere bulk -j 120i -i sysutils/node_exporter shells/bash textproc/gsed net-mgmt/prometheus2

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21895
Build 21139: arc lint + arc unit

Event Timeline

0mp created this revision.Wed, Jan 9, 3:48 PM
0mp edited the summary of this revision. (Show Details)Wed, Jan 9, 3:49 PM
0mp edited the summary of this revision. (Show Details)
dor added a subscriber: dor.Thu, Jan 17, 3:16 PM

This looks pretty great. I had been wondering about this recently for the prometheus2 port :)