Page MenuHomeFreeBSD

devel/libevdev, devel/libmtdev: advertise evdev-proto as API dependency
AbandonedPublic

Authored by jbeich on Jan 9 2019, 1:33 PM.

Details

Reviewers
hselasky
wulf
Group Reviewers
x11
Summary

libevdev/libmtdev cannot be used unless evdev-proto is installed. requiring evdev-proto upstream projects that use libevdev/libmtdev no longer need to check for FreeBSD-specific package.

$ fgrep -r linux/input.h /usr/local/include
/usr/local/include/libevdev-1.0/libevdev/libevdev.h:#include <linux/input.h>
/usr/local/include/libevdev-1.0/libevdev/libevdev.h: * linux/input.h shipped with libevdev.
/usr/local/include/libevdev-1.0/libevdev/libevdev.h: * @include linux/input.h
/usr/local/include/libevdev-1.0/libevdev/libevdev.h: * meaning, matching the axis names in linux/input.h. Some devices merely
/usr/local/include/mtdev.h:#include <linux/input.h>

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21894
Build 21138: arc lint + arc unit

Event Timeline

jbeich created this revision.Jan 9 2019, 1:33 PM
jbeich updated this revision to Diff 52692.Jan 9 2019, 2:01 PM

Drop evdev-proto from libinput consumers as well

hselasky accepted this revision.Jan 9 2019, 2:36 PM

I don't see any issues here. And I'm not a ports expert :-)

This revision is now accepted and ready to land.Jan 9 2019, 2:36 PM
wulf added a comment.Jan 9 2019, 3:00 PM

linux/input.h is a list of magic numbers required at build time only. It should be kept in BUILD_DEPENDS IMO.

jbeich abandoned this revision.Jan 20 2019, 4:38 PM