Page MenuHomeFreeBSD

devel/libevdev, devel/libmtdev: advertise evdev-proto as API dependency
AbandonedPublic

Authored by jbeich on Jan 9 2019, 1:33 PM.
Tags
None
Referenced Files
F103493291: D18791.diff
Mon, Nov 25, 5:35 PM
Unknown Object (File)
Sun, Nov 24, 4:25 PM
Unknown Object (File)
Sat, Nov 23, 6:57 PM
Unknown Object (File)
Sat, Nov 23, 9:14 AM
Unknown Object (File)
Sat, Nov 23, 2:58 AM
Unknown Object (File)
Tue, Nov 19, 9:25 PM
Unknown Object (File)
Mon, Nov 11, 3:54 AM
Unknown Object (File)
Sun, Nov 10, 1:42 AM

Details

Reviewers
hselasky
wulf
Group Reviewers
x11
Summary

libevdev/libmtdev cannot be used unless evdev-proto is installed. requiring evdev-proto upstream projects that use libevdev/libmtdev no longer need to check for FreeBSD-specific package.

$ fgrep -r linux/input.h /usr/local/include
/usr/local/include/libevdev-1.0/libevdev/libevdev.h:#include <linux/input.h>
/usr/local/include/libevdev-1.0/libevdev/libevdev.h: * linux/input.h shipped with libevdev.
/usr/local/include/libevdev-1.0/libevdev/libevdev.h: * @include linux/input.h
/usr/local/include/libevdev-1.0/libevdev/libevdev.h: * meaning, matching the axis names in linux/input.h. Some devices merely
/usr/local/include/mtdev.h:#include <linux/input.h>

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21894
Build 21138: arc lint + arc unit

Event Timeline

Drop evdev-proto from libinput consumers as well

I don't see any issues here. And I'm not a ports expert :-)

This revision is now accepted and ready to land.Jan 9 2019, 2:36 PM

linux/input.h is a list of magic numbers required at build time only. It should be kept in BUILD_DEPENDS IMO.