Page MenuHomeFreeBSD

Add OPTIONS for a better Plasma 5 desktop and Falkon experience
ClosedPublic

Authored by adridg on Dec 29 2018, 3:00 PM.

Details

Summary

There are various RUN_DEPENDS that you're told to install via
pkg-message, but we may as well install them by default when
building packages. GStreamer is installed already through other
dependencies, so the additional packages are small, and this
means that sound Just Works with both the browser and the desktop.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

adridg created this revision.Dec 29 2018, 3:00 PM
tcberner requested changes to this revision.Dec 29 2018, 3:11 PM
tcberner added inline comments.
x11/plasma5-plasma/Makefile
23 ↗(On Diff #52394)

^ I think this is the wrong place for these.

x11/plasma5-plasma-workspace or x11/plasma5-plasma-desktop seem the btter choices, as this one is just the metaport. So people with minimal installations will not profit from it.

26 ↗(On Diff #52394)

^_DESC?

30 ↗(On Diff #52394)

^ this could be USE_QT=phonon-gst -- but I thing phonon should leave qt.mk ... so ...

This revision now requires changes to proceed.Dec 29 2018, 3:11 PM
adridg updated this revision to Diff 52395.Dec 29 2018, 3:13 PM

Improve the RUN_DEPENDS with better syntax

adridg updated this revision to Diff 52407.Dec 29 2018, 9:35 PM

Persist in having the option in the wrong place, but add plasma-pa option (OFF)

adridg updated this revision to Diff 52410.Dec 29 2018, 9:51 PM

Move PINENTRY option to where it is most needed

adridg updated this revision to Diff 52411.Dec 29 2018, 10:00 PM

Forgot PORTREVISION, also make OPTIONS_DEFAULT explicit

tcberner accepted this revision.Dec 29 2018, 10:15 PM

I would drop the ASLA and PULSEAUDIO _DESCs and use the ones provided by bsd.options.desc.mk. For phonon I would keep the one you defined.

www/falkon/Makefile
32 ↗(On Diff #52411)

^ ALSA_DESC is already provided by bsd.options.desc.mk

x11/plasma5-plasma/Makefile
27 ↗(On Diff #52411)

^ this is also available in bsd.options.desc.mk

This revision is now accepted and ready to land.Dec 29 2018, 10:15 PM
This revision was automatically updated to reflect the committed changes.