There are various RUN_DEPENDS that you're told to install via
pkg-message, but we may as well install them by default when
building packages. GStreamer is installed already through other
dependencies, so the additional packages are small, and this
means that sound Just Works with both the browser and the desktop.
Details
Details
- Reviewers
tcberner - Commits
- rP488719: Add OPTIONS to some kde@ ports.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| x11/plasma5-plasma/Makefile | ||
|---|---|---|
| 23 ↗ | (On Diff #52394) | ^ I think this is the wrong place for these. x11/plasma5-plasma-workspace or x11/plasma5-plasma-desktop seem the btter choices, as this one is just the metaport. So people with minimal installations will not profit from it. |
| 26 ↗ | (On Diff #52394) | ^_DESC? |
| 30 ↗ | (On Diff #52394) | ^ this could be USE_QT=phonon-gst -- but I thing phonon should leave qt.mk ... so ... |
Comment Actions
I would drop the ASLA and PULSEAUDIO _DESCs and use the ones provided by bsd.options.desc.mk. For phonon I would keep the one you defined.
| www/falkon/Makefile | ||
|---|---|---|
| 32 ↗ | (On Diff #52411) | ^ ALSA_DESC is already provided by bsd.options.desc.mk |
| x11/plasma5-plasma/Makefile | ||
| 27 ↗ | (On Diff #52411) | ^ this is also available in bsd.options.desc.mk |