Page MenuHomeFreeBSD

Allow overriding rust dependency
ClosedPublic

Authored by jbeich on Dec 22 2018, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 10:35 PM
Unknown Object (File)
Fri, Mar 15, 10:35 PM
Unknown Object (File)
Fri, Mar 15, 10:35 PM
Unknown Object (File)
Fri, Mar 15, 10:35 PM
Unknown Object (File)
Tue, Mar 12, 3:10 AM
Unknown Object (File)
Jan 7 2024, 4:43 PM
Unknown Object (File)
Dec 31 2023, 1:03 AM
Unknown Object (File)
Dec 20 2023, 12:14 AM
Subscribers

Details

Summary

In order to prepare for future lang/rust updates, facilitate upstreaming (including new platform support), test nightly->stable workarounds (devel/racer, textproc/ripgrep) and debugging it maybe desirable to build consumers using lang/rust-nightly. So, let's expose RUST_CHANNEL via DEFAULT_VERSIONS where empty/unset RUST_DEFAULT would imply stable.

Test Plan

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21688
Build 20975: arc lint + arc unit

Event Timeline

tobik requested changes to this revision.Dec 23 2018, 3:55 AM
tobik added a subscriber: tobik.

I don't have any objections to the idea, but I'd rather the values for RUST_DEFAULT are the package names rust and rust-nightly (similar to SSL_DEFAULT, ignoring base...) as all of the depends would be much simpler. Having an empty RUST_DEFAULT value select lang/rust is weird and I'd like the depends line to be immediately obvious to anyone. It also needs to be documented in bsd.default-versions.mk.

DEFAULT_VERSIONS+=	rust=rust-nightly

BUILD_DEPENDS+=	${RUST_DEFAULT}>=1.31.0:lang/${RUST_DEFAULT}
This revision now requires changes to proceed.Dec 23 2018, 3:55 AM
  • Address @tobik's comment
  • Mark as 2019Q1 candidate
This revision is now accepted and ready to land.Jan 3 2019, 8:59 AM
This revision was automatically updated to reflect the committed changes.