New port: math/bcal: Storage expression, unit conversion & address offset CLI calculator

[0mp]

Summary

https://github.com/jarun/bcal

Test Plan

• portlint
• poudriere testport
  • 11.2 amd64
  • 12.0 amd64

[mat]

math/bcal/Makefile

5–6

This is wrong.

DISTVERSION=        2.1-1
​DISTVERSIONSUFFIX=        -g8636e33

8

You are mixing USE_GITHUB and a normal file download, this seems wrong.

You should either download a git-archive(1) extract using USE_GITHUB, or use a download URL. The latest one seems to be https://github.com/jarun/bcal/releases/download/v2.1/bcal-v2.1.tar.gz.

[0mp]

Thank you for the review, @mat! I'm really grateful for your time. The revision
wasn't ready, however, this is why I've not added you and @krion as reviewers.
I'll try to make it more obvious next time ;)

Changes:

• Update version. Many compatibility issues related to FreeBSD where solved recently. For the time being, use the current head of the master branch instead of the last revision (v2.1). As a result:
  • No longer depend on gnubc.
  • Simplify MAKE_ENV.
  • Remove custom patches.

[mat]

Well, you should not use Phabricator as a place to dump the patches you are working on, use git and branches or something.

math/bcal/Makefile

6–7

This is still wrong, -12 should be in DISTVERSION.

[0mp]

Fix DISTVERSION.

[mat]

math/bcal/Makefile

25

DISTDIR seems wrong, should be PREFIX or something.

28

man pages go in man/manX, not share/man/manX.

[0mp]

• Install manpages under a correct directory.

[0mp]

• Correct version format.

[0mp]

Revert the previous change.