Details
Details
- portlint
- poudriere testport
- 11.2 amd64
- 12.0 amd64
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
math/bcal/Makefile | ||
---|---|---|
5–6 ↗ | (On Diff #52003) | This is wrong. DISTVERSION= 2.1-1 DISTVERSIONSUFFIX= -g8636e33 |
8 ↗ | (On Diff #52003) | You are mixing USE_GITHUB and a normal file download, this seems wrong. You should either download a git-archive(1) extract using USE_GITHUB, or use a download URL. The latest one seems to be https://github.com/jarun/bcal/releases/download/v2.1/bcal-v2.1.tar.gz. |
Comment Actions
Thank you for the review, @mat! I'm really grateful for your time. The revision
wasn't ready, however, this is why I've not added you and @krion as reviewers.
I'll try to make it more obvious next time ;)
Changes:
- Update version. Many compatibility issues related to FreeBSD where solved recently. For the time being, use the current head of the master branch instead of the last revision (v2.1). As a result:
- No longer depend on gnubc.
- Simplify MAKE_ENV.
- Remove custom patches.
Comment Actions
Well, you should not use Phabricator as a place to dump the patches you are working on, use git and branches or something.
math/bcal/Makefile | ||
---|---|---|
5–6 ↗ | (On Diff #52103) | This is still wrong, -12 should be in DISTVERSION. |