Since python is enabled by default, this keeps the version with the
default python version as 'gdb' and adds a package suffix for other
python versions.
Details
Details
- Reviewers
pizzamig - Commits
- rP490337: Enable separate flavors for different python versions.
- poudriere testport of both flavors and build of devel/gdb@all built both
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| devel/gdb/Makefile | ||
|---|---|---|
| 88–92 ↗ | (On Diff #51933) | No. PKGNAMESUFFIX= ${PYTHON_PKGNAMESUFFIX}And I would really rather it be non optional. |
| devel/gdb/Makefile | ||
|---|---|---|
| 88–92 ↗ | (On Diff #51933) | See my thread on ports@ for why this negatively impacts the user experience. If it has to be non-optional I'll just drop the flavors instead. |
Comment Actions
I agree with John, about the suffix only for not default python version.
I need a bit of time, to properly test it.
Comment Actions
Maybe it is my english not being correct, but I thought "I would rather" meant something that would be nice but not required.
The other change was, on the other hand, required.
Comment Actions
Would it be better to use 'USES_PYTHON=optsuffix' (even though it's marked deprecated) instead of explicitly setting PKGNAMESUFFIX?
Comment Actions
LGTM
totally agree with John, about package naming: by default the package should be called gdb. The gdb-py36 should be used for the special case only.