New port: x11-fonts/tamzen: Monospace bitmap font forked from Tamsyn

[tobik]

Some comments below.

And a disclaimer that even a positive review is not a promise to commit something. You should always also open a PR on https://bugs.freebsd.org (if you haven't already) to get this into the patch queue.

head/x11-fonts/tamzen/Makefile

16

If you properly set DISTVERSIONPREFIX=Tamzen- instead of GH_TAGNAME below, this wouldn't be necessary.

18–22

Wrong place in the Makefile. See 15. Order of Variables in Port Makefiles.

head/x11-fonts/tamzen/pkg-plist

3

These are not vt(4) fonts. Probably they are Windows Font Files.

Please do not add them, if you have not tested loading them.

[mat]

head/x11-fonts/tamzen/Makefile

39

Add blank line between targets.

[voidanix_420blaze.it]

Attemp fixes

[tobik]

head/x11-fonts/tamzen/Makefile

10

But "for the console" is no longer true now?

23

OPTIONS_SUB isn't needed anymore now.

25–26

Both NO_BUILD and NO_ARCH are standard bsd.port.mk variables, so they are not really in the correct position here.

[voidanix_420blaze.it]

@tobik is there any way I can get this port committed? I can't commit this yet :p

[mat]

In D18451#395629, @voidanix_420blaze.it wrote:

@tobik is there any way I can get this port committed? I can't commit this yet :p

This tool, here, Phabricator, is a code review tool, not a patch queue for things to be committed, which is what Bugzilla is for.
If you are not a committer, or do not plan to commit it yourself, it is best to always open a PR on our bugzilla in parallel so that the change actually goes in our pipeline.

[voidanix_420blaze.it]

In D18451#396062, @mat wrote:

In D18451#395629, @voidanix_420blaze.it wrote:

@tobik is there any way I can get this port committed? I can't commit this yet :p

This tool, here, Phabricator, is a code review tool, not a patch queue for things to be committed, which is what Bugzilla is for.
If you are not a committer, or do not plan to commit it yourself, it is best to always open a PR on our bugzilla in parallel so that the change actually goes in our pipeline.

I asked about the port being committed as I've opened a PR on Bugzilla a few days ago as well, here.
Sorry for the noise anyways.