Page MenuHomeFreeBSD

deskutils/py-autokey: a desktop automation utility for X11
ClosedPublic

Authored by daniel_shafer.cc on Dec 2 2018, 8:22 AM.

Details

Summary

Allows you to configure macros to auto input text/scripts
when certain inputs are made.

Related bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232801

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner added inline comments.
deskutils/py-autokey/Makefile
1 ↗(On Diff #51490)

^ the 'Created by:' line is a historic line. It is preferred not to add it anymore, unless you really want to :)

5 ↗(On Diff #51490)

^ I would prefer DISTVERSION

34 ↗(On Diff #51490)

^ if you name this option GTK3 you can drop the GTK_DESC below, as
GTK3_DESC?= GTK+ 3 GUI toolkit support
is defined in bsd.options.desc.mk.

The same goes for QT, if you use QT5 as an option name.

41 ↗(On Diff #51490)

^ in the FOO_USE= BAR=list1 BAZ=list2 the lists need to be comma separated, not space, as the spaces are used to split into the multiple lists.

You can verify via
make -VUSE_GNOME
that only the first one made it in :)

so, what you want is:
GTK_USE= GNOME=gtk30,pygopbject,gtksourceview3

deskutils/py-autokey/files/patch-setup.py
7 ↗(On Diff #51490)

out of curiostiy: why is this necessary?

deskutils/py-autokey/pkg-plist
105 ↗(On Diff #51490)

^all these 36 look like your chosen python version :) -- so it will only be able to package for python3.6

daniel_shafer.cc updated this revision to Diff 51502.EditedDec 2 2018, 10:32 PM

Updates

Removed pkg-plist and using autoplist. Removed patch file and added logic
to Makefile. Made requested changes. Cleaned up ordering.

Removed the INSTALLS_ICONS variable as icons are installed through setup.py

daniel_shafer.cc marked 4 inline comments as done.Dec 30 2018, 4:29 AM

All requested changes were made with my most recent diff, however, I forgot to check the boxes and submit.

tcberner added inline comments.Dec 30 2018, 11:59 AM
deskutils/py-autokey/Makefile
10 ↗(On Diff #51520)

^

Macro this-is-freebsd:

deskutils/py-autokey/pkg-descr
1 ↗(On Diff #51520)

^ if you can, make this a bit longer

deskutils/py-autokey/Makefile
44 ↗(On Diff #51520)
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: bin/autokey-qt
Error: Missing: man/man1/autokey-qt.1.gz
Error: Missing: share/applications/autokey-qt.desktop

Renamed UI to GUI as it's a builtin option.
Fixed pkg-plist issues.
Updated description to use FreeBSD instead of Linux.
Updated pkg-descr with more content.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2018, 8:52 PM
This revision was automatically updated to reflect the committed changes.