Page MenuHomeFreeBSD

ubldr: Fix booting PowerPC kernels
AbandonedPublic

Authored by jhibbits on Wed, Nov 28, 2:09 AM.

Details

Reviewers
imp
nwhitehorn
Group Reviewers
PowerPC
Summary

Book-E powerpc kernels expect the device tree to be the first argument.
Match the powerpc/ofw ofw_exec function for powerpc. Also, since powerpc gates
passing the device tree on the 'usefdt' environment variable, force-set this
like for loader.kboot.

Test Plan

Test booted on an AmigaOne A1222

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 21233
Build 20576: arc lint + arc unit

Event Timeline

jhibbits created this revision.Wed, Nov 28, 2:09 AM
mizhka_gmail.com added inline comments.
stand/uboot/lib/elf_freebsd.c
94–95

I wonder what is magic constant?

jhibbits marked an inline comment as done.Wed, Nov 28, 12:43 PM
jhibbits added inline comments.
stand/uboot/lib/elf_freebsd.c
94–95

Nathan put this magic constant in for PowerPC booting, to denote booting with the new loader, about a year ago, with the goal of distinguishing r6 as having a real metadata pointer instead of potentially garbage. Right now everything beyond dtbp is not used, but it will be in the future, as I bring booke booting up to parity with AIM.

jhibbits abandoned this revision.Thu, Dec 6, 6:02 PM

No need for this anymore. Only needed the "usefdt" change, the rest was fixed in the kernel.