Page MenuHomeFreeBSD

ubldr: Fix booting PowerPC kernels
AbandonedPublic

Authored by jhibbits on Nov 28 2018, 2:09 AM.

Details

Reviewers
imp
nwhitehorn
Group Reviewers
PowerPC
Summary

Book-E powerpc kernels expect the device tree to be the first argument.
Match the powerpc/ofw ofw_exec function for powerpc. Also, since powerpc gates
passing the device tree on the 'usefdt' environment variable, force-set this
like for loader.kboot.

Test Plan

Test booted on an AmigaOne A1222

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 21233
Build 20576: arc lint + arc unit

Event Timeline

mizhka added inline comments.
stand/uboot/lib/elf_freebsd.c
94–95

I wonder what is magic constant?

jhibbits added inline comments.
stand/uboot/lib/elf_freebsd.c
94–95

Nathan put this magic constant in for PowerPC booting, to denote booting with the new loader, about a year ago, with the goal of distinguishing r6 as having a real metadata pointer instead of potentially garbage. Right now everything beyond dtbp is not used, but it will be in the future, as I bring booke booting up to parity with AIM.

No need for this anymore. Only needed the "usefdt" change, the rest was fixed in the kernel.