Fix routing sysctl leaks.
ClosedPublic
Actions

Authored by markj on Nov 25 2018, 10:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 28, 5:33 PM

	Unknown Object (File)
	Tue, Nov 25, 9:59 AM

	Unknown Object (File)
	Fri, Nov 21, 1:38 AM

	Unknown Object (File)
	Fri, Nov 21, 1:36 AM

	Unknown Object (File)
	Fri, Nov 21, 1:33 AM

	Unknown Object (File)
	Fri, Nov 21, 1:31 AM

	Unknown Object (File)
	Tue, Nov 18, 1:32 AM

	Unknown Object (File)
	Thu, Nov 13, 5:51 AM

View All 99 Files

Subscribers

imp

Details

Reviewers

Commits

rS340968: Plug routing sysctl leaks.

Summary

Some of the structures exported by sysctl_rtsock() contain padding
fields. A few of these were explicitly zeroed, but some were not. For
now, fix the problem by identifying the remaining pad fields and
clearing them.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 25 2018, 10:28 PM

Herald added a subscriber: ae. · View Herald TranscriptNov 25 2018, 10:28 PM

markj added a reviewer: ae.Nov 25 2018, 10:29 PM

Harbormaster completed remote builds in B21201: Diff 51094.Nov 25 2018, 10:31 PM

LGTM.

This revision is now accepted and ready to land.Nov 26 2018, 8:45 AM

Closed by commit rS340968: Plug routing sysctl leaks. (authored by markj). · Explain WhyNov 26 2018, 1:42 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 26 2018, 1:42 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if.h

4 lines

route.h

1 line

rtsock.c

16 lines

Diff 51114

View Options

head/sys/net/if.h

View Options

head/sys/net/route.h

View Options

Fix routing sysctl leaks.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51114

head/sys/net/if.h

head/sys/net/route.h

head/sys/net/rtsock.c

Fix routing sysctl leaks.
ClosedPublic
Actions

Revision Contents
Changeset List