Page MenuHomeFreeBSD

top(1): Add missing display messages when toggling modes
ClosedPublic

Authored by james.wright_jigsawdezign.com on Nov 25 2018, 3:33 PM.

Details

Reviewers
eadler
markj
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rS341346: Add missing display messages when toggling modes.
Summary

Added missing display messaging when toggling by the following;

m : "Displaying IO stats" / "Displaying CPU stats"
S: "Displaying system processes" / "Not displaying system processes"
a: "Displaying process args" / "Not displaying process args"

Bugzilla;
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233667

Test Plan
  1. Run patched top
  2. Verify display of relevant message when toggling on/off;

m : "Displaying IO stats" / "Displaying CPU stats"
S: "Displaying system processes" / "Not displaying system processes"
a: "Displaying process args" / "Not displaying process args"

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj accepted this revision.Nov 25 2018, 5:26 PM

Seems reasonable to me.

This revision is now accepted and ready to land.Nov 25 2018, 5:26 PM
markj added a comment.Nov 30 2018, 5:42 PM

Sorry, I meant to commit this. That said, after looking at top.c I have a couple of nits: is there any reason to abbreviate "args" and "stats"? We don't seem to do that in general (e.g., "processes" instead of "procs"), and other messages spell out "statistics." Second, other messages end with a period, so we should do that here too.

Updated with regards to feedback suggested by markj

Was unsure about ending the messages with a period as there is already a mixture in the existing code. I have included the period as suggested in these new messages and removed any abbreviations.

This revision now requires review to proceed.Nov 30 2018, 5:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 6:04 PM
Closed by commit rS341346: Add missing display messages when toggling modes. (authored by markj, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: Restricted Owners Package.Nov 30 2018, 6:04 PM