Page MenuHomeFreeBSD

science/erkale: Please approve flavorization: serial and parallel
ClosedPublic

Authored by yuri on Nov 23 2018, 9:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 9, 12:15 AM
Unknown Object (File)
Jan 10 2024, 10:42 AM
Unknown Object (File)
Dec 23 2023, 2:17 AM
Unknown Object (File)
Nov 26 2023, 8:17 AM
Unknown Object (File)
Nov 14 2023, 8:22 AM
Unknown Object (File)
Nov 12 2023, 8:23 AM
Unknown Object (File)
Nov 11 2023, 7:11 AM
Unknown Object (File)
Nov 10 2023, 9:01 PM

Details

Summary

Serial and parallel version can be installed concurrently.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

science/erkale/Makefile
24 ↗(On Diff #51020)

Please use flavor helpers.

45–47 ↗(On Diff #51020)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

yuri marked 2 inline comments as done.Nov 24 2018, 9:53 AM
yuri added inline comments.
science/erkale/Makefile
24 ↗(On Diff #51020)

Like this:

serial_PKGNAMESUFFIX= -serial
parallel_PKGNAMESUFFIX= -parallel

?
It is 2 lines, isn't it worse?

science/erkale/Makefile
24 ↗(On Diff #51020)

No, it is more clear, also, you may want to only change the package name for the non default option, as people running pkg upgrade will not get the new package.

yuri marked 2 inline comments as done.Nov 25 2018, 6:33 PM
science/erkale/Makefile
24 ↗(On Diff #51091)

Remove this one.

This revision is now accepted and ready to land.Dec 6 2018, 3:32 PM