Page MenuHomeFreeBSD
Differential D18288

sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:59 AM.
Tags
None
Referenced Files
F154320357: D18288.diff
Mon, Apr 27, 8:00 PM
Unknown Object (File)
Thu, Apr 23, 1:49 AM
Unknown Object (File)
Wed, Apr 22, 8:32 AM
Unknown Object (File)
Sun, Apr 19, 1:45 PM
Unknown Object (File)
Sun, Apr 19, 11:12 AM
Unknown Object (File)
Sun, Apr 5, 4:23 PM
Unknown Object (File)
Mar 28 2026, 9:46 PM
Unknown Object (File)
Mar 28 2026, 5:37 AM
View All 95 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342522: MFC r341327
rS342451: MFC r341327
rS342343: MFC r341327
rS341327: sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped
Summary

Early processing of a packet on transmit may change last seen
VLAN TCI in the queue context. If such a packet is eventually
dropped, last seen VLAN TCI must be set to its previous value.

Submitted by: Ivan Malov <Ivan.Malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:59 AM
Harbormaster completed remote builds in B21147: Diff 50888.Nov 21 2018, 11:59 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:11 AM
Closed by commit rS341327: sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:11 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
4 lines

Diff 51421

View Options

head/sys/dev/sfxge/sfxge_tx.c

Loading...