Dump OBJT_PHYS objects in ELF core dumps.
ClosedPublic
Actions

Authored by jhb on Feb 12 2015, 5:05 PM.

Details

Reviewers

kib
alc

Commits

rS278761: Include OBJT_PHYS VM objects in ELF core dumps. In particular this

Summary

Include OBJT_PHYS VM objects in ELF core dumps. In particular this
includes the shared page allowing debuggers to use the signal trampoline
code to identify signal frames in core dumps.

Test Plan

Verify that a gdb patched to use a sigcode sniffer to identify signal frames works with a core generated via the kernel and one via gcore.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jhb updated this revision to Diff 3747.Feb 12 2015, 5:05 PM

jhb retitled this revision from to Dump OBJT_PHYS objects in ELF core dumps..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added reviewers: kib, alc.

alc accepted this revision.Feb 12 2015, 5:17 PM

alc edited edge metadata.

This revision is now accepted and ready to land.Feb 12 2015, 5:17 PM

kib accepted this revision.Feb 12 2015, 5:21 PM

kib edited edge metadata.

kib added inline comments.

sys/kern/imgact_elf.c
1405 ↗	(On Diff #3747)	Explicit listing of object types is fine. It might be simpler to check for !OBJ_FICTITIOUS flag, and type != OBJT_DEAD.

jhb added inline comments.Feb 12 2015, 8:12 PM

sys/kern/imgact_elf.c
1405 ↗	(On Diff #3747)	While in general I think we prefer using flags checks, we don't export the flags to userland and I'd like to keep the gcore code aligned with this (even though currently they are a bit different)

Closed by commit rS278761 (authored by @jhb).

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

imgact_elf.c

3 lines

usr.bin/

gcore/

elfcore.c

3 lines

Diff 3767

View Options

head/sys/kern/imgact_elf.c