Page MenuHomeFreeBSD

sfxge(4): check buffer size for hash flags
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 15 2024, 3:42 AM
Unknown Object (File)
Dec 23 2023, 2:43 AM
Unknown Object (File)
Nov 15 2023, 6:04 PM
Unknown Object (File)
Nov 11 2023, 3:36 PM
Unknown Object (File)
Nov 9 2023, 3:37 PM
Unknown Object (File)
Oct 14 2023, 5:06 PM
Unknown Object (File)
Oct 8 2023, 2:33 PM
Unknown Object (File)
Sep 4 2023, 3:28 PM
Subscribers

Details

Summary

The efx_rx_scale_hash_flags_get interface is unsafe, as it does not
have an argument for the size of the output buffer used to return
the flags. While the only caller currently supplies a sufficiently
large buffer, this should be checked at runtime to avoid writing
past the end of the buffer.

Submitted by: Ivan Malov <ivan.malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM
This revision was automatically updated to reflect the committed changes.