Page MenuHomeFreeBSD
Differential D18259

sfxge(4): fix out of bounds read when dereferencing sdup
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 9:33 AM
Unknown Object (File)
Sun, Nov 17, 9:22 PM
Unknown Object (File)
Tue, Nov 5, 3:26 PM
Unknown Object (File)
Oct 21 2024, 5:15 PM
Unknown Object (File)
Oct 21 2024, 5:14 PM
Unknown Object (File)
Oct 21 2024, 5:14 PM
Unknown Object (File)
Oct 21 2024, 4:54 PM
Unknown Object (File)
Oct 11 2024, 7:30 PM
View All 39 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342516: MFC r341297
rS342445: MFC r341297
rS342344: MFC r341297
rS341297: sfxge(4): fix out of bounds read when dereferencing sdup
Summary

Introduce and use macro to make sure that MCDI buffers allocated
on stack are rounded up properly.

Submitted by: Gautam Dawar <gdawar at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:54 AM
Harbormaster completed remote builds in B21117: Diff 50858.Nov 21 2018, 11:54 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM
Closed by commit rS341297: sfxge(4): fix out of bounds read when dereferencing sdup (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
28 lines
15 lines
5 lines
20 lines
93 lines
19 lines
35 lines
10 lines
39 lines
11 lines
82 lines
5 lines
40 lines
6 lines
17 lines
9 lines
5 lines
5 lines
28 lines

Diff 51392

View Options

head/sys/dev/sfxge/common/ef10_ev.c

Loading...
View Options

head/sys/dev/sfxge/common/ef10_filter.c

Loading...
View Options

head/sys/dev/sfxge/common/ef10_intr.c

Loading...
View Options

head/sys/dev/sfxge/common/ef10_mac.c

Loading...
View Options

head/sys/dev/sfxge/common/ef10_nic.c

Loading...
View Options

head/sys/dev/sfxge/common/ef10_phy.c

Loading...
View Options

head/sys/dev/sfxge/common/ef10_rx.c

Loading...
View Options

head/sys/dev/sfxge/common/ef10_tx.c

Loading...
View Options

head/sys/dev/sfxge/common/efx_lic.c

Loading...
View Options

head/sys/dev/sfxge/common/efx_mcdi.h

Loading...
View Options

head/sys/dev/sfxge/common/efx_mcdi.c

Loading...
View Options

head/sys/dev/sfxge/common/efx_nic.c

Loading...
View Options

head/sys/dev/sfxge/common/efx_nvram.c

Loading...
View Options

head/sys/dev/sfxge/common/efx_tunnel.c

Loading...
View Options

head/sys/dev/sfxge/common/mcdi_mon.c

Loading...
View Options

head/sys/dev/sfxge/common/siena_mac.c

Loading...
View Options

head/sys/dev/sfxge/common/siena_nic.c

Loading...
View Options

head/sys/dev/sfxge/common/siena_nvram.c

Loading...
View Options

head/sys/dev/sfxge/common/siena_phy.c

Loading...