sfxge(4): avoid usage of too big arrays on stack
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 23, 6:22 AM

	Unknown Object (File)
	Thu, Apr 23, 5:39 AM

	Unknown Object (File)
	Tue, Apr 21, 7:50 PM

	Unknown Object (File)
	Sun, Apr 19, 3:10 PM

	Unknown Object (File)
	Sat, Apr 18, 9:23 PM

	Unknown Object (File)
	Tue, Apr 14, 10:35 AM

	Unknown Object (File)
	Sat, Mar 28, 3:54 AM

	Unknown Object (File)
	Mar 7 2026, 4:22 PM

View All Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342515: MFC r341295
rS342444: MFC r341295
rS342337: MFC r341295
rS341295: sfxge(4): avoid usage of too big arrays on stack

Summary

Found by PreFAST static analysis.

Submitted by: Martin Harvey <mharvey at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:54 AM

Harbormaster completed remote builds in B21115: Diff 50856.Nov 21 2018, 11:54 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM

Closed by commit rS341295: sfxge(4): avoid usage of too big arrays on stack (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

ef10_phy.c

18 lines

efx_nvram.c

27 lines

Diff 51390

View Options

head/sys/dev/sfxge/common/ef10_phy.c