Differential D18256

sfxge(4): generalise EF10 NVRAM buffer interface
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 6, 8:34 PM

	Unknown Object (File)
	Wed, Nov 5, 6:41 AM

	Unknown Object (File)
	Tue, Nov 4, 10:28 PM

	Unknown Object (File)
	Wed, Oct 29, 8:55 AM

	Unknown Object (File)
	Sat, Oct 25, 5:30 PM

	Unknown Object (File)
	Sat, Oct 25, 5:06 PM

	Unknown Object (File)
	Sat, Oct 25, 11:53 AM

	Unknown Object (File)
	Sat, Oct 25, 11:53 AM

View All 66 Files

Subscribers

Details

Reviewers

gnn
philip

Commits

rS341294: sfxge(4): generalise EF10 NVRAM buffer interface

Summary

The SFN driver's PartitionControl WMI object requires an API to parse
and filter partition data in TLV format, particularly for the Dynamic
Config partition. The ef10_nvram_buffer functions provide this
functionality but are tied to use with license partition only.
Modify functions so they are applicable to all TLV partitions and add
functions to support in-place tag modification.

Submitted by: Richard Houldsworth <rhouldsworth at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:54 AM

Harbormaster completed remote builds in B21114: Diff 50855.Nov 21 2018, 11:54 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM

Closed by commit rS341294: sfxge(4): generalise EF10 NVRAM buffer interface (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

43 lines

153 lines

2 lines

15 lines

2 lines

Diff 51389

head/sys/dev/sfxge/common/ef10_impl.h

Loading...

head/sys/dev/sfxge/common/ef10_nvram.c

Loading...

head/sys/dev/sfxge/common/efx_impl.h

Loading...

head/sys/dev/sfxge/common/efx_lic.c

Loading...

head/sys/dev/sfxge/common/efx_nvram.c

Loading...