Page MenuHomeFreeBSD

sfxge(4): remove probes when a Tx queue is too full
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 2:51 PM
Unknown Object (File)
Tue, Dec 17, 10:50 AM
Unknown Object (File)
Sat, Dec 7, 1:28 PM
Unknown Object (File)
Sep 27 2024, 5:09 AM
Unknown Object (File)
Sep 24 2024, 5:10 PM
Unknown Object (File)
Sep 24 2024, 11:40 AM
Unknown Object (File)
Sep 20 2024, 6:34 AM
Unknown Object (File)
Sep 16 2024, 5:02 AM
Subscribers

Details

Summary

No need for probe messages when a TxQ is too full for a post to be done.

Existing drivers check if there is room in the queue before posting
descriptors, even though efx_tx_qdesc_post() does the check itself.

The new SFN Windows driver doesn't perform the check before calling
efx_tx_qdesc_post(), but that means these probes can get frequently
printed out. It's normal driver behaviour so there's no need to print
an error.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 5:54 AM
This revision was automatically updated to reflect the committed changes.