Page MenuHomeFreeBSD
Differential D18229

sfxge(4): cope with clang warning on negative shift
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 4, 8:39 AM
Unknown Object (File)
Sun, Jan 19, 8:55 PM
Unknown Object (File)
Oct 1 2024, 3:55 AM
Unknown Object (File)
Sep 8 2024, 1:10 AM
Unknown Object (File)
Sep 7 2024, 8:15 PM
Unknown Object (File)
Sep 7 2024, 5:45 AM
Unknown Object (File)
Sep 4 2024, 10:35 PM
Unknown Object (File)
Aug 24 2024, 10:07 PM
View All 23 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341198: sfxge(4): cope with clang warning on negative shift
Summary

clang 4.0.1-6 on Ubuntu generates false positive warning that shift
is negative. It is done regardless of the fact that the branch is
not taken because of previous check.

The warning is generate in EFX_INSERT_NATIVE32 used by
EFX_INSERT_FIELD_NATIVE32. All similar cases are fixed as well.

It is undesirable to suppress the warning completely.

Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:48 AM
Harbormaster completed remote builds in B21087: Diff 50828.Nov 21 2018, 11:48 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2018, 6:44 AM
Closed by commit rS341198: sfxge(4): cope with clang warning on negative shift (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 6:44 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
38 lines

Diff 51326

View Options

head/sys/dev/sfxge/common/efx_types.h

Loading...