Page MenuHomeFreeBSD
Differential D18228

sfxge(4): fix comparison always true warning
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:48 AM.
Tags
None
Referenced Files
F147283315: D18228.id51325.diff
Mon, Mar 9, 4:35 PM
Unknown Object (File)
Mon, Mar 9, 9:21 AM
Unknown Object (File)
Sat, Mar 7, 12:13 PM
Unknown Object (File)
Sat, Mar 7, 10:37 AM
Unknown Object (File)
Sat, Mar 7, 7:14 AM
Unknown Object (File)
Sat, Mar 7, 6:25 AM
Unknown Object (File)
Sat, Mar 7, 4:12 AM
Unknown Object (File)
Sat, Mar 7, 12:24 AM
View All Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342510: MFC r341197
rS342439: MFC r341197
rS342332: MFC r341197
rS341197: sfxge(4): fix comparison always true warning
Summary

Loopback type used as bit index has efx_loopback_type_t type
which is enum. clang complains that it is always true when it
is compared with qword (64 bit) bits number boundary.

Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:48 AM
Harbormaster completed remote builds in B21086: Diff 50827.Nov 21 2018, 11:48 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2018, 6:44 AM
Closed by commit rS341197: sfxge(4): fix comparison always true warning (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 6:44 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
2 lines

Diff 51325

View Options

head/sys/dev/sfxge/common/efx_port.c

Loading...