sfxge(4): use MAC stats DMA buffer size when decoding
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 24, 3:10 PM

	Unknown Object (File)
	Dec 22 2023, 10:03 PM

	Unknown Object (File)
	Jun 8 2023, 6:16 PM

	Unknown Object (File)
	May 14 2023, 6:22 PM

	Unknown Object (File)
	Apr 25 2023, 6:42 PM

	Unknown Object (File)
	Apr 24 2023, 11:48 PM

	Unknown Object (File)
	Apr 20 2023, 7:28 AM

	Unknown Object (File)
	Jan 5 2023, 1:21 PM

View All 10 Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS341062: sfxge(4): use MAC stats DMA buffer size when decoding

Summary

On Medford2 and later the MAC stats buffer has been enlarged.
Use the MAC stats DMA buffer size to ensure that the stats END
generation count is read from the correct location, and that
over-reading of the DMA buffer is prevented.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:39 AM

Harbormaster completed remote builds in B21034: Diff 50775.Nov 21 2018, 11:39 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 2:16 PM

Closed by commit rS341062: sfxge(4): use MAC stats DMA buffer size when decoding (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 27 2018, 2:16 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

ef10_mac.c

50 lines

siena_mac.c

29 lines

Diff 51204

View Options

head/sys/dev/sfxge/common/ef10_mac.c