Differential D18130

sfxge(4): remove Falcon-specific concurrency check
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:27 AM.

Tags

None

Referenced Files

	F135760378: D18130.diff
	Wed, Nov 12, 2:24 PM

	Unknown Object (File)
	Wed, Nov 12, 5:50 AM

	Unknown Object (File)
	Sat, Oct 25, 8:29 PM

	Unknown Object (File)
	Fri, Oct 24, 3:09 PM

	Unknown Object (File)
	Fri, Oct 24, 3:09 PM

	Unknown Object (File)
	Fri, Oct 24, 3:09 PM

	Unknown Object (File)
	Fri, Oct 24, 5:56 AM

	Unknown Object (File)
	Sat, Oct 18, 12:46 AM

View All 60 Files

Subscribers

Details

Reviewers

gnn
philip

Commits

rS342331: MFC r340896
rS340896: sfxge(4): remove Falcon-specific concurrency check

Summary

Falcon support has been withdrawn from libefx, however, there is still
an obsolete Falcon-specific assertion that efx_mac_stats_upload()
and efx_port_poll() aren't concurrent. To be consistent with an overall
Falcon support revocation it's desirable to remove it.

Fix debug build invalid assertion failure.

Submitted by: Ivan Malov <ivan.malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:27 AM

Harbormaster completed remote builds in B20986: Diff 50727.Nov 21 2018, 11:27 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM

Closed by commit rS340896: sfxge(4): remove Falcon-specific concurrency check (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

1 line

9 lines

1 line

Diff 51067

head/sys/dev/sfxge/common/efx_impl.h

Loading...

head/sys/dev/sfxge/common/efx_mac.c

Loading...

head/sys/dev/sfxge/common/efx_port.c

Loading...