Page MenuHomeFreeBSD
Differential D18128

sfxge(4): fix PreFAST static analysis warning (C6001)
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 9:24 AM
Unknown Object (File)
Fri, Nov 21, 8:44 AM
Unknown Object (File)
Thu, Nov 20, 9:29 PM
Unknown Object (File)
Thu, Nov 20, 9:27 PM
Unknown Object (File)
Thu, Nov 20, 9:26 PM
Unknown Object (File)
Thu, Nov 20, 9:15 PM
Unknown Object (File)
Tue, Nov 18, 10:13 PM
Unknown Object (File)
Tue, Nov 18, 5:30 PM
View All 85 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342506: MFC r340894
rS342435: MFC r340894
rS342329: MFC r340894
rS340894: sfxge(4): fix PreFAST static analysis warning (C6001)
Summary

Fix warning
"C6001: Using uninitialized memory '*sensor_maskp'"
which could occur when the npages argument to efx_mcdi_sensor_info()
is less than or equal to zero.

Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:26 AM
Harbormaster completed remote builds in B20984: Diff 50725.Nov 21 2018, 11:26 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM
Closed by commit rS340894: sfxge(4): fix PreFAST static analysis warning (C6001) (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
13 lines

Diff 51065

View Options

head/sys/dev/sfxge/common/mcdi_mon.c

Loading...