Page MenuHomeFreeBSD

sfxge(4): fix warnings from VS2015 C compiler (C4100)
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 7:34 AM
Unknown Object (File)
Mon, Jun 22, 9:41 AM
Unknown Object (File)
Fri, Jun 19, 3:33 PM
Unknown Object (File)
Tue, Jun 16, 3:46 PM
Unknown Object (File)
Thu, Jun 11, 8:51 PM
Unknown Object (File)
May 12 2026, 2:07 PM
Unknown Object (File)
Apr 28 2026, 9:28 PM
Unknown Object (File)
Apr 28 2026, 9:23 PM
Subscribers

Details

Summary

Fix multiple level 4 warnings
"C4100: 'xxx': unreferenced formal parameter"
no functional changes.

The _NOTE(ARGUNUSED(xxx)) annotations are being exposed to the Visual
Studio 2015 C compiler with the following:

#define _NOTE_ARGUNUSED(...) UNREFERENCED_PARAMETER((__VA_ARGS__));
#define _NOTE(_annotation)   _NOTE_ ## _annotation

Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM
This revision was automatically updated to reflect the committed changes.