Page MenuHomeFreeBSD
Differential D18120

sfxge(4): fix warnings from VS2015 C compiler (C4244)
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 19, 7:50 AM
Unknown Object (File)
Wed, Sep 17, 9:49 PM
Unknown Object (File)
Sep 14 2025, 8:41 AM
Unknown Object (File)
Sep 7 2025, 12:38 AM
Unknown Object (File)
Aug 12 2025, 12:43 PM
Unknown Object (File)
Jul 26 2025, 7:00 AM
Unknown Object (File)
Jul 13 2025, 3:56 AM
Unknown Object (File)
Jun 30 2025, 1:37 PM
View All 53 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342499: MFC r340886
rS342428: MFC r340886
rS342318: MFC r340886
rS340886: sfxge(4): fix warnings from VS2015 C compiler (C4244)
Summary

Fix level 4 warning
"C4244: '+=': conversion from 'unsigned int' to 'uint16_t', possible loss
of data"; no functional changes.

Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:25 AM
Harbormaster completed remote builds in B20976: Diff 50717.Nov 21 2018, 11:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM
Closed by commit rS340886: sfxge(4): fix warnings from VS2015 C compiler (C4244) (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
2 lines

Diff 51058

View Options

head/sys/dev/sfxge/common/efx_vpd.c

Loading...