sfxge(4): fix probes in licensing support
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:25 AM.

Tags

None

Referenced Files

	F168654230: D18118.diff
	Sat, Aug 29, 11:13 AM

	Unknown Object (File)
	Tue, Aug 25, 2:03 AM

	Unknown Object (File)
	Tue, Aug 25, 12:39 AM

	Unknown Object (File)
	Sun, Aug 23, 10:45 PM

	Unknown Object (File)
	Fri, Aug 21, 7:47 PM

	Unknown Object (File)
	Fri, Aug 21, 6:42 PM

	Unknown Object (File)
	Fri, Aug 21, 10:56 AM

	Unknown Object (File)
	Fri, Aug 21, 2:35 AM

View All Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342497: MFC r340884
rS342426: MFC r340884
rS342316: MFC r340884
rS340884: sfxge(4): fix probes in licensing support

Summary

EFSYS_PROBE1 takes one typed value (in addition to the probe name),
whereas EFSYS_PROBE has just the probe name.

Which to use is determined by the probe name – “fail1” probes are
expected to include the function result.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:25 AM

Harbormaster completed remote builds in B20974: Diff 50715.Nov 21 2018, 11:25 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM

Closed by commit rS340884: sfxge(4): fix probes in licensing support (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

efx_lic.c

6 lines

Diff 51055

View Options

head/sys/dev/sfxge/common/efx_lic.c

sfxge(4): fix probes in licensing supportClosedPublicActions