Page MenuHomeFreeBSD

sfxge(4): ignore error in completion event on MCDIv2 HW
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 4:11 PM
Unknown Object (File)
Thu, Sep 25, 7:48 PM
Unknown Object (File)
Sep 12 2025, 11:23 AM
Unknown Object (File)
Sep 4 2025, 10:29 PM
Unknown Object (File)
Aug 15 2025, 4:41 PM
Unknown Object (File)
Jul 29 2025, 10:02 AM
Unknown Object (File)
Jul 17 2025, 1:02 AM
Unknown Object (File)
Jul 10 2025, 10:20 PM
Subscribers

Details

Summary

With MCDIv2, the reponse length can be to big to fit into the
CMDDONE_DATALEN field in the MCDI completion event. But rather that
the length being truncated, it can overflow into the CMDDONE_ERRNO
field (this is a longstanding firmware bug). Hence the CMDDONE_ERRNO
field may not be valid.

It isn't necessary to use the value in the CMDDONE_ERRNO field though,
so it can be ignored. The actual error code is already read from the
response header on MCDIv2 capable hardware and stored in emr_rc, so
that can be used instead.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 4:00 PM
This revision was automatically updated to reflect the committed changes.