Page MenuHomeFreeBSD

sfxge(4): precheck and verify flash writes
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 28, 4:07 PM
Unknown Object (File)
Sun, Sep 21, 12:16 AM
Unknown Object (File)
Aug 26 2025, 2:35 PM
Unknown Object (File)
Aug 26 2025, 11:06 AM
Unknown Object (File)
Aug 25 2025, 10:34 AM
Unknown Object (File)
Aug 25 2025, 10:32 AM
Unknown Object (File)
Aug 4 2025, 5:25 AM
Unknown Object (File)
Jul 26 2025, 10:11 PM
Subscribers

Details

Summary

Read existing flash content before writing, so the flash write can be
avoided if the existing partition content matches the new image. This
avoids unnecessary write cycles for the flash device, and may also be
faster. If the flash does need to be updated, verify the content after
writing.

Note that reading the flash content after writing but before calling
efx_nvram-rw_finish() avoids firmware bug68170, which can lead to
signed image updates failing on Medford.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 10:21 AM
This revision was automatically updated to reflect the committed changes.