Page MenuHomeFreeBSD

sfxge(4): rename API to check Rx scale and hash support
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 8 2024, 10:36 PM
Unknown Object (File)
Dec 20 2023, 2:08 AM
Unknown Object (File)
Sep 20 2023, 11:45 PM
Unknown Object (File)
Jun 19 2023, 2:28 PM
Unknown Object (File)
Jun 15 2023, 7:07 PM
Unknown Object (File)
Jun 3 2023, 7:47 AM
Unknown Object (File)
May 24 2023, 10:14 AM
Unknown Object (File)
Feb 1 2023, 6:15 AM
Subscribers

Details

Summary

Rename efx_rx_scale_support_get() to efx_rx_scale_default_support_get(),
and efx_rx_hash_support_get() to efx_rx_hash_default_support_get().

All these really report is whether an exclusive RSS context was
successfully acquired at efx_rx_init().

efx_rx_scale_support_get() sounds like it reports whether the device
supports RSS, and whether exclusive or shared contexts are supported,
but it doesn't do that. Renaming it to
efx_rx_scale_default_support_get() helps to reflect that it reports
what RSS support the client gets without trying to allocate RSS
contexts itself.

Also rename efx_rx_scale_support_t to efx_rx_scale_context_type_t, to
make the enum more suitable for specifying the type of an RSS context
to be allocated.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 9:15 AM
This revision was automatically updated to reflect the committed changes.