Differential D17957

netdump: Fix netdumping with INVARIANTS kernels
ClosedPublic
Actions

Authored by cem on Nov 12 2018, 2:37 AM.

Tags

None

Referenced Files

	F154269220: D17957.id.diff
	Mon, Apr 27, 12:26 PM

	F154239064: D17957.id50298.diff
	Mon, Apr 27, 8:28 AM

	Unknown Object (File)
	Sun, Apr 26, 1:23 PM

	Unknown Object (File)
	Tue, Apr 21, 10:08 AM

	Unknown Object (File)
	Tue, Apr 21, 10:04 AM

	Unknown Object (File)
	Tue, Apr 21, 6:29 AM

	Unknown Object (File)
	Tue, Apr 21, 6:23 AM

	Unknown Object (File)
	Mon, Apr 20, 2:14 PM

Subscribers

Details

Reviewers

Commits

rS340358: netdump: Fix netdumping with INVARIANTS kernels

Summary

Correct boneheaded assertion I added in r339501. Mea culpa.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Nov 12 2018, 2:37 AM

Harbormaster completed remote builds in B20760: Diff 50298.Nov 12 2018, 2:37 AM

markj accepted this revision.Nov 12 2018, 3:53 AM

markj added inline comments.

sys/kern/kern_mbuf.c
422 ↗	(On Diff #50298)	Really, this function should never get called while !dumping is true. I think you can just remove that test.
462 ↗	(On Diff #50298)	Ditto.

This revision is now accepted and ready to land.Nov 12 2018, 3:53 AM

cem marked an inline comment as done.Nov 12 2018, 3:57 AM

cem added inline comments.

sys/kern/kern_mbuf.c
422 ↗	(On Diff #50298)	OK

Removing '!dumping||' portion of assert condition -- it would always be false
anyway. Per markj.

This revision now requires review to proceed.Nov 12 2018, 3:59 AM

Harbormaster completed remote builds in B20762: Diff 50300.Nov 12 2018, 3:59 AM

markj accepted this revision.Nov 12 2018, 4:09 AM

This revision is now accepted and ready to land.Nov 12 2018, 4:09 AM

Closed by commit rS340358: netdump: Fix netdumping with INVARIANTS kernels (authored by cem). · Explain WhyNov 12 2018, 5:24 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 12 2018, 5:24 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

8 lines

Diff 50302

head/sys/kern/kern_mbuf.c

Loading...