Page MenuHomeFreeBSD

netdump: Fix netdumping with INVARIANTS kernels
ClosedPublic

Authored by cem on Nov 12 2018, 2:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 1, 2:01 PM
Unknown Object (File)
Tue, Sep 30, 3:11 AM
Unknown Object (File)
Mon, Sep 29, 12:34 AM
Unknown Object (File)
Sun, Sep 28, 9:45 PM
Unknown Object (File)
Sun, Sep 28, 9:06 AM
Unknown Object (File)
Sat, Sep 27, 8:39 PM
Unknown Object (File)
Sat, Sep 27, 7:36 PM
Unknown Object (File)
Mon, Sep 22, 7:21 AM
Subscribers

Details

Summary

Correct boneheaded assertion I added in r339501. Mea culpa.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
sys/kern/kern_mbuf.c
422 ↗(On Diff #50298)

Really, this function should never get called while !dumping is true. I think you can just remove that test.

462 ↗(On Diff #50298)

Ditto.

This revision is now accepted and ready to land.Nov 12 2018, 3:53 AM
cem marked an inline comment as done.Nov 12 2018, 3:57 AM
cem added inline comments.
sys/kern/kern_mbuf.c
422 ↗(On Diff #50298)

OK

cem marked 2 inline comments as done.

Removing '!dumping||' portion of assert condition -- it would always be false
anyway. Per markj.

This revision now requires review to proceed.Nov 12 2018, 3:59 AM
This revision is now accepted and ready to land.Nov 12 2018, 4:09 AM
This revision was automatically updated to reflect the committed changes.