Page MenuHomeFreeBSD
Differential D1789

Document the WITNESS_COUNT and WITNESS_NO_VNODE kernel options
ClosedPublic
Actions

Authored by ngie on Feb 6 2015, 11:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 7, 8:12 PM
Unknown Object (File)
Tue, Sep 29, 2:40 PM
Unknown Object (File)
Tue, Sep 29, 3:42 AM
Unknown Object (File)
Tue, Sep 29, 3:30 AM
Unknown Object (File)
Mon, Sep 28, 2:50 PM
Unknown Object (File)
Sun, Sep 27, 11:36 PM
Unknown Object (File)
Sun, Sep 27, 11:02 PM
Unknown Object (File)
Sun, Sep 27, 8:15 PM
View All Files
Subscribers
bcr
benno
brueffer
Doc Committers

Details

Reviewers
kib
bcr
Summary

Document the WITNESS_COUNT and WITNESS_NO_VNODE kernel options

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ngie updated this revision to Diff 3661.Feb 6 2015, 11:06 AM
ngie retitled this revision from to Document the WITNESS_COUNT and WITNESS_NO_VNODE kernel options.
ngie updated this object.
ngie added a reviewer: kib.
ngie added a subscriber: benno.
ngie added a subscriber: Doc Committers.Feb 6 2015, 11:07 AM
kib added inline comments.Feb 6 2015, 11:13 AM
share/man/man4/witness.4
81

It does not. The option silences all LORs where vnode locks participate, not only known false positives.

ngie updated this revision to Diff 3662.Feb 6 2015, 11:18 AM

Update WITNESS_NO_VNODE per kib's feedback to note that LORs between 2 VNODE
type locks are ignored when the option is set in the kernel

ngie added a comment.Feb 6 2015, 11:21 AM
  • I'm not sure if "two" is a good quantifier for WITNESS_NO_VNODE (even though that's what the code does today).
  • Not quite sure about the verbiage with the term [witness] objects. Technically they're locks, so I suppose I should say locks, not objects..?
kib edited edge metadata.Feb 6 2015, 11:41 AM

Remove the 'two'. Correctly formulating this is beyond the usefulness of the man page.

ngie updated this revision to Diff 3663.Feb 6 2015, 12:04 PM
ngie edited edge metadata.

Remove 'two' as suggested by kib@

brueffer added a subscriber: brueffer.Feb 6 2015, 12:09 PM

Looks good to me.

kib accepted this revision.Feb 6 2015, 12:21 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2015, 12:21 PM
bcr accepted this revision.Feb 6 2015, 1:31 PM
bcr added a reviewer: bcr.
bcr added a subscriber: bcr.

Same here from the doc side of things.

ngie closed this revision.Feb 6 2015, 8:48 PM

Addressed in r278329 -- thank you!

Revision Contents
Changeset List

PathSize
share/
man/
man4/
24 lines

Diff 3663

View Options

share/man/man4/witness.4

Loading...