Page MenuHomeFreeBSD
Differential D17703

Add a note about the Aberdeen hackathon to the event list for 2019.
ClosedPublic
Actions

Authored by 0mp on Oct 25 2018, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 11 2025, 10:54 PM
Unknown Object (File)
Nov 24 2025, 7:02 AM
Unknown Object (File)
Nov 22 2025, 6:01 PM
Unknown Object (File)
Nov 19 2025, 6:33 PM
Unknown Object (File)
Nov 19 2025, 6:33 PM
Unknown Object (File)
Nov 19 2025, 6:33 PM
Unknown Object (File)
Nov 19 2025, 6:33 PM
Unknown Object (File)
Nov 19 2025, 6:33 PM
View All 61 Files
Subscribers
None

Details

Reviewers
bcr
thj
Commits
rD52405: Add a note about the Aberdeen hackathon to the event list for 2019.
Test Plan

The generated website looks fine.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Oct 25 2018, 4:55 PM
Harbormaster completed remote builds in B20423: Diff 49618.Oct 25 2018, 4:55 PM
thj added inline comments.Oct 25 2018, 4:59 PM
share/xml/events2019.xml
94 ↗(On Diff #49618)

Country is United Kingdom, or Scotland. Certainly not Belgium

0mp updated this revision to Diff 49619.Oct 25 2018, 5:10 PM
  • Set country to United Kingdom.
  • Wrap long lines.
Harbormaster completed remote builds in B20424: Diff 49619.Oct 25 2018, 5:10 PM
0mp marked an inline comment as done.Oct 25 2018, 5:10 PM

Haha, good catch, @thj

thj accepted this revision.Oct 25 2018, 5:13 PM
This revision is now accepted and ready to land.Oct 25 2018, 5:13 PM
bcr added inline comments.Oct 25 2018, 5:50 PM
share/xml/events2019.xml
97 ↗(On Diff #49619)

The </site> tag should be right after the last word on the previous line.

0mp marked an inline comment as done.Oct 25 2018, 7:11 PM
0mp added inline comments.
share/xml/events2019.xml
97 ↗(On Diff #49619)

Are you sure? It's too long to fit in one line (at least that's what vim told me) :/

bcr added a comment.Oct 25 2018, 7:14 PM

Well, in that case, you need to wrap the last word ("213" or even "room") to the next line, but the </site> tag needs to be there, no space.

0mp updated this revision to Diff 49629.Oct 25 2018, 7:36 PM

Improve formatting of the site tag.

This revision now requires review to proceed.Oct 25 2018, 7:36 PM
Harbormaster completed remote builds in B20431: Diff 49629.Oct 25 2018, 7:37 PM
0mp marked an inline comment as done.Oct 25 2018, 7:37 PM
bcr accepted this revision.Oct 25 2018, 7:50 PM

Excellent, ready for commit.

This revision is now accepted and ready to land.Oct 25 2018, 7:50 PM
Closed by commit rD52405: Add a note about the Aberdeen hackathon to the event list for 2019. (authored by 0mp). · Explain WhyOct 25 2018, 8:05 PM
This revision was automatically updated to reflect the committed changes.
0mp added a comment.Oct 25 2018, 8:11 PM

Wonderful! Thanks!

Revision Contents
Changeset List

PathSize
head/
share/
xml/
26 lines

Diff 49630

View Options

head/share/xml/events2019.xml

Loading...