Page MenuHomeFreeBSD
Differential D17538

amd64: import updated kernel memmove to libc
ClosedPublic
Actions

Authored by mjg on Oct 12 2018, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 1:15 PM
Unknown Object (File)
Tue, Nov 19, 1:15 PM
Unknown Object (File)
Tue, Nov 19, 1:15 PM
Unknown Object (File)
Tue, Nov 19, 1:15 PM
Unknown Object (File)
Tue, Nov 19, 12:53 PM
Unknown Object (File)
Tue, Nov 19, 3:20 AM
Unknown Object (File)
Oct 14 2024, 6:24 AM
Unknown Object (File)
Sep 30 2024, 4:51 AM
View All 50 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS339347: amd64: import updated kernel memmove to libc
Summary

bcopy is left alone as it is expected to be converted to a C func.

Due to header mess ALIGN_TEXT is temporarily defined explicitly in memmove.S

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.Oct 12 2018, 7:55 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 12 2018, 7:55 PM
Harbormaster completed remote builds in B20168: Diff 49072.Oct 12 2018, 7:55 PM
kib added inline comments.Oct 13 2018, 4:37 PM
lib/libc/amd64/string/memmove.S
28 ↗(On Diff #49072)

Do you need two tags ?

39 ↗(On Diff #49072)

Is it still true statement ?

mjg updated this revision to Diff 49102.EditedOct 13 2018, 6:13 PM
  • drop extra fbsd tag
  • reword the attribution comment

The code is definitely no longer 'adapted', but it still contains some of the original bcopy (initial overlap check and part of copying backwards with rep stosq). I'm not comfortable dropping the comment without approval from the author.

kib accepted this revision.Oct 13 2018, 6:48 PM
kib added inline comments.
lib/libc/amd64/string/memmove.S
39 ↗(On Diff #49102)

May be also add a note similar to 'try to keep in sync with <kernel file path>'

This revision is now accepted and ready to land.Oct 13 2018, 6:48 PM
mjg marked an inline comment as done.Oct 13 2018, 6:50 PM
mjg added inline comments.
lib/libc/amd64/string/memmove.S
39 ↗(On Diff #49102)

I'll do a separate pass to also cover memset.

Closed by commit rS339347: amd64: import updated kernel memmove to libc (authored by mjg). · Explain WhyOct 13 2018, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
amd64/
string/
4 lines
273 lines

Diff 49113

View Options

head/lib/libc/amd64/string/memcpy.S

Loading...
View Options

head/lib/libc/amd64/string/memmove.S

Loading...