Page MenuHomeFreeBSD

Add VCHI driver to HEAD
ClosedPublic

Authored by gonzo on Feb 2 2015, 3:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 28, 8:11 AM
Unknown Object (File)
May 2 2024, 11:50 AM
Unknown Object (File)
Jan 14 2024, 10:20 PM
Unknown Object (File)
Dec 22 2023, 9:33 AM
Unknown Object (File)
Nov 5 2023, 7:22 PM
Unknown Object (File)
Oct 31 2023, 1:47 AM
Unknown Object (File)
Oct 29 2023, 1:23 PM
Unknown Object (File)
Oct 4 2023, 6:20 PM
Subscribers
None

Details

Reviewers
adrian
Summary

VCHI driver switched to BSD license more then a year ago and it's essential for GPU/audio support on RaspberryPi.

Test Plan
  • Run VCHI userland demos
  • Run quake3

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gonzo retitled this revision from to Add VCHI driver to HEAD .
gonzo updated this object.
gonzo edited the test plan for this revision. (Show Details)
gonzo added reviewers: ian, adrian.

So far:

  • Please delete or #if 0 out the RCU stuff - you said on IRC that we're not using it. I'd just like to ensure that the minimum amount of stuff in the compat layer is used. Otherwise we may see some update start using code that was previously dead in list.h (and other compat code) that hasn't been tested.
  • We need to go and ensure that all of the calls to the allocator functions handle NULLs - linux doesn't return NULL for small allocations and I've been bitten by drivers that don't check. (But - we can do this post-commit.)
  • Does the kmalloc() glue require M_ZERO? It may be a performance boost if we're using it correctly everywhere. Actually, we're not using it in this patch - so #if 0 it out, remove M_ZERO from it.

Other than that, the general review is "grr linux code with no OS agnostic layer, sigh Linux." But it's a good starting point. I think we need to get the busdma stuff looked at in closer depth and I'll go hammer the heck out of it once it's in -HEAD.

  • I removed unused macroses/functions from list.h
  • M_ZERO is required at the moment. mtx/cv initializers expect the memory to be zero-ed.
adrian edited edge metadata.

OK. Let's land this and then sort through the busdma things as people are using it.

This revision is now accepted and ready to land.Feb 4 2015, 9:01 PM
gonzo removed a reviewer: ian.
gonzo removed a reviewer: gonzo.