Page MenuHomeFreeBSD
Differential D17507

pfctl: Dup strings
ClosedPublic
Actions

Authored by kp on Oct 10 2018, 4:35 PM.
Tags
None
Referenced Files
F140941371: D17507.id49340.diff
Mon, Dec 29, 10:04 PM
Unknown Object (File)
Nov 29 2025, 1:24 AM
Unknown Object (File)
Nov 26 2025, 3:29 PM
Unknown Object (File)
Nov 21 2025, 8:54 PM
Unknown Object (File)
Nov 20 2025, 8:52 PM
Unknown Object (File)
Nov 20 2025, 8:52 PM
Unknown Object (File)
Nov 20 2025, 8:49 PM
Unknown Object (File)
Nov 20 2025, 8:42 PM
View All Files
Subscribers
eri
imp

Details

Reviewers
eri
Group Reviewers
network
Commits
rS339464: pfctl: Dup strings
Summary

When we set the ifname we have to copy the string, rather than just keep
the pointer.

PR: 231323
Sponsored by: Klara

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Oct 10 2018, 4:35 PM
Harbormaster completed remote builds in B20124: Diff 48982.Oct 10 2018, 4:35 PM
kp added a reviewer: network.Oct 10 2018, 4:36 PM
kp set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptOct 10 2018, 4:36 PM
eri accepted this revision.Oct 14 2018, 4:07 PM
eri added a subscriber: eri.

Looks good.

This revision is now accepted and ready to land.Oct 14 2018, 4:07 PM
Closed by commit rS339464: pfctl: Dup strings (authored by kp). · Explain WhyOct 20 2018, 6:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sbin/
pfctl/
4 lines

Diff 49340

View Options

head/sbin/pfctl/parse.y

Loading...