Page MenuHomeFreeBSD

Flavorize net-im/telepathy-qt[45] -> net-im/telepathy-qt@[qt4,qt5]
ClosedPublic

Authored by tcberner on Oct 6 2018, 12:13 AM.

Details

Summary
  • Create flavors
  • Clean up Makefile

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat added inline comments.
net-im/telepathy-qt/Makefile
25 ↗(On Diff #48816)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

54–55 ↗(On Diff #48816)

This could probably be USES=uniquefiles:dirs.

flavors bits looks good.

Reoder option, use uniquedir, and remove uneeded change in plist-sub

uniquefiles:dirs didn't take, so I switched back to the maual override.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 7 2018, 1:43 PM
This revision was automatically updated to reflect the committed changes.