Details

Reviewers

mat
tcberner

Group Reviewers

kde

Commits

rD52352: Introduce USES=qt to the Porter's Handbook

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobik created this revision.Oct 5 2018, 7:11 AM

Herald added 1 blocking reviewer(s): mat. · View Herald TranscriptOct 5 2018, 7:11 AM

Harbormaster completed remote builds in B19994: Diff 48767.Oct 5 2018, 7:11 AM

mat added inline comments.Oct 5 2018, 7:24 AM

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2958 ↗	(On Diff #48767)	`+=` is a good idea.
3127 ↗	(On Diff #48767)	I'd rather you omit other changes like this.
3152 ↗	(On Diff #48767)	No.
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
2672 ↗	(On Diff #48767)	`no_env` does not seem to be documented.

Harbormaster completed remote builds in B19998: Diff 48771.Oct 5 2018, 7:52 AM

tobik added inline comments.Oct 5 2018, 7:56 AM

en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
2672 ↗	(On Diff #48767)	Hmm, it doesn't seem to do anything in USES=qt. Looks like the usage comment at the top of `qt.mk` is not correct.

See also my neglected D15972 .

tcberner added inline comments.Oct 5 2018, 8:05 AM

en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
2672 ↗	(On Diff #48767)	no_env gets interpreted by qmake.mk

Bring in additional changes from @tcberner D15972

Harbormaster completed remote builds in B19999: Diff 48773.Oct 5 2018, 8:15 AM

Change more USE_QTx
Document additonal USES=qmake args

Harbormaster completed remote builds in B20001: Diff 48776.Oct 5 2018, 8:52 AM

Fix some typos

Harbormaster completed remote builds in B20002: Diff 48777.Oct 5 2018, 9:07 AM

tcberner added inline comments.Oct 5 2018, 8:06 PM

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2868 ↗	(On Diff #48777)	^ no_configure and no_env are mostly for internal use [and very broken software].
2951 ↗	(On Diff #48777)	^ I'm not sure at the moment if that made it into the committed version :) -- it works for qt-dist.mk, but I have to double check for qmake.mk

Mk/bsd.qt.mk -> Mk/Uses/qt.mk

Harbormaster completed remote builds in B20022: Diff 48819.Oct 6 2018, 4:22 AM

Remove USES=qmake:4 tip again as it doesn't actually work

Harbormaster completed remote builds in B20023: Diff 48820.Oct 6 2018, 4:36 AM

tobik marked 3 inline comments as done.Oct 6 2018, 4:40 AM

tobik added inline comments.

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2612–2631 ↗	(On Diff #48819)	I wonder if these paragraphs should be removed or moved to the qmake section instead (with QT_NONSTANDARD -> `USES= qmake:no_env`)? qt.mk does not seem to modify CONFIGURE_{ENV,ARGS} much on its own.
2868 ↗	(On Diff #48777)	Should I a) remove the description of `no_env` and `no_configure` again? b) add a "For interal use only." note? c) add a warning that they probably shouldn't be used by porters?
2951 ↗	(On Diff #48777)	Trying to build a port with just `USES=qmake:5` or `USES=qmake:4` fails with: Incorrect 'USES+= qmake' usage: argument '4' is not recognized. I'll remove the tip again.

tcberner added inline comments.Oct 6 2018, 7:04 AM

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2868 ↗	(On Diff #48777)	I think I prefer c) something like "In most cases these are not needed"

mat added inline comments.Oct 6 2018, 8:31 AM

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2612–2631 ↗	(On Diff #48819)	Ah, yes, `QT_NONSTANDARD` was removed some time ago, I missed that.
2868 ↗	(On Diff #48777)	I would phrase this a bit differently, something along the lines of `if the software breaks this or that way, use no_env/no_configure`. The goal of the handbook is to help porters port software, it is better to say "use in this case" rather than "you will probably not need it".
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
2672 ↗	(On Diff #48767)	You should add `no_env` back, it is a valid argument, maybe saying that it is passed to qmake.

tcberner added inline comments.Oct 6 2018, 9:09 AM

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2868 ↗	(On Diff #48777)	no-configure: required if the software requires qmake, and the environnent variables set by qmake.mk at build time, but the build system is not qmake based no-env: required when qmake is used to configure the software, but fails to understand the environment setup by qmake.mk.

Harbormaster completed remote builds in B20028: Diff 48825.Oct 6 2018, 11:06 AM

Sounds good to me

mat added inline comments.Oct 6 2018, 1:52 PM

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
2853–2854 ↗	(On Diff #48825)	Extra \n inside <literal>.
2861–2862 ↗	(On Diff #48825)	There's an extra "\n" inside the <command> tag.
2989 ↗	(On Diff #48825)	Remove extra blank line.