math/openblas: Update to 0.3.3 introducing flavors.openblas has the option INTERFACE64.
Needs ReviewPublic
Actions

Authored by yuri on Sep 27 2018, 8:46 AM.

Details

Reviewers: None

Summary

Most packages don't need it (they use the 32-bit interface), but some packages need INTERFACE64. cmake option INTERFACE64=1 installs a separate version of openblas with all different files.
Ports that need INTERFACE64 should depend on the @interface64 flavor.

math/openblas: Update to 0.3.3 introducing flavors.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 19856
Build 19384: arc lint + arc unit

Event Timeline

yuri created this revision.Sep 27 2018, 8:46 AM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptSep 27 2018, 8:46 AM

Harbormaster completed remote builds in B19834: Diff 48498.Sep 27 2018, 8:46 AM

mat added inline comments.Sep 27 2018, 11:47 AM

math/openblas/Makefile
43–45	Please use helpers when possible.
97–98	Set variables before all targets.

Use helpers.

Updating D17333: math/openblas: Update to 0.3.3 introducing flavors.

openblas has the option INTERFACE64. Most packages don't beed it (they use the 32-bit interface),
but some packages need INTERFACE64.

cmake option INTERFACE64=1 installs a spearate version of...

Harbormaster completed remote builds in B19854: Diff 48541.Sep 28 2018, 1:58 AM

yuri retitled this revision from math/openblas: Update to 0.3.3 introducing flavors. openblas has the option INTERFACE64. Most packages don't beed it (they use the 32-bit interface), but some packages need INTERFACE64. cmake option INTERFACE64=1 installs a spearate version of... to math/openblas: Update to 0.3.3 introducing flavors.openblas has the option INTERFACE64..Sep 28 2018, 1:59 AM

yuri edited the summary of this revision. (Show Details)

mat added inline comments.Sep 28 2018, 6:36 AM

math/openblas/Makefile
80–81	This should probably force the DYNAMIC_ARCH option using OPTIONS_SLAVE instead of bailing out.

The DYNAMIC_ARCH option allows to build code for different architectures in one binary on amd64 and i386.
It should be ok to just have it "on" by default.

Harbormaster completed remote builds in B19855: Diff 48543.Sep 28 2018, 8:13 AM

Harbormaster completed remote builds in B19856: Diff 48544.Sep 28 2018, 8:16 AM

yuri marked an inline comment as done.Sep 28 2018, 8:16 AM

I do not think it should be possible to disable the dynamic thing when PACKAGE_BUILDING.

In D17333#370000, @mat wrote:

I do not think it should be possible to disable the dynamic thing when PACKAGE_BUILDING.

Now the dynamic option is a default, so it will be always enabled with PACKAGE_BUILDING.
But local in the local build this option can be disabled.

Default does not mean enabled.

In D17333#370441, @mat wrote:

Default does not mean enabled.

OPTIONS_DEFAULT is described as List of options activated by default which makes it enabled (activated) in the package by default.

OPTIONS_DEFAULT makes an option the *default*, it does not enable them, the options can be changed, for example by running make config, or if for instance running poudriere, using poudriere options. So, if, when BUILDING_PACKAGES, the option has to be enabled, adding it to OPTIONS_DEFAULT is not enough.

In D17333#370938, @mat wrote:

OPTIONS_DEFAULT makes an option the *default*, it does not enable them, the options can be changed, for example by running make config, or if for instance running poudriere, using poudriere options. So, if, when BUILDING_PACKAGES, the option has to be enabled, adding it to OPTIONS_DEFAULT is not enough.

Yes, I understand that option values can be changed by setting config values, including in poudriere. This is ok. Nothing says that this option absolutely has to be ON no matter what. If user decides to set it OFF through config, this is fine.