Page MenuHomeFreeBSD
Differential D17236

Improve loader passwords
ClosedPublic
Actions

Authored by trasz on Sep 19 2018, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 1:09 AM
Unknown Object (File)
Sat, Nov 23, 6:11 PM
Unknown Object (File)
Nov 14 2024, 4:02 AM
Unknown Object (File)
Nov 13 2024, 5:44 AM
Unknown Object (File)
Oct 24 2024, 4:23 PM
Unknown Object (File)
Oct 24 2024, 4:23 PM
Unknown Object (File)
Oct 24 2024, 4:23 PM
Unknown Object (File)
Oct 24 2024, 4:02 PM
View All 35 Files
Subscribers
imp

Details

Reviewers
kevans
Commits
rS338886: Improve loader passwords:
Summary

Improve loader passwords:

  1. Be clear about which password is being requested
  2. Remove extraneous whitespace between the prompt and the cursor
  3. Move the twiddle to where the prompt is, instead of two characters to the right
  4. Fix erasing the 'incorrect password' message when retrying; previously it was erased partially
  5. Remove the unneeded exclamation mark

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Sep 19 2018, 1:50 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 19 2018, 1:50 PM
Harbormaster completed remote builds in B19667: Diff 48210.Sep 19 2018, 1:50 PM
trasz edited the summary of this revision. (Show Details)Sep 19 2018, 1:52 PM
trasz added a reviewer: kevans.
kevans accepted this revision.Sep 19 2018, 4:25 PM

I don't have time to do a thorough review/test, but nothing here offends my greater sensibilities so it looks good to me if you've tested it. =)

This revision is now accepted and ready to land.Sep 19 2018, 4:25 PM
Closed by commit rS338886: Improve loader passwords: (authored by trasz). · Explain WhySep 22 2018, 1:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
stand/
lua/
19 lines

Diff 48355

View Options

head/stand/lua/password.lua

Loading...