irc/bitchx: update to 1.2.1
- update to 1.2.1
PR: 195526
DiffRev: placeholder
Submitted by: Chris Petrik <chris@bsdjunk.com>
Approved by: koobs (mentor)
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| irc/bitchx/Makefile | ||
|---|---|---|
| 4 | You probably want PORTVERSION here, since DISTVERSION was used in the current version because of the -final suffix | |
| 4–5 | Remove PORTREVISION after confirming 1.2.1 is > 1.2-final (version comparison using pkg) If not, you need a PORTEPOCH bump (if 1.2.1 is lower) | |
| 9–10 | Why do we need ?= Slave ports? | |
| 10–12 | Why do we need ?= Slave ports? | |
| 14 | Explain perl5 removal? Your commit log only contains - Update to 1.2.1 but nothing more. Please include all changes/intents | |
| 20 | Why isn't/can't this be LDFLAGS=? | |
| 29 | Sort these OPTIONS | |
| 32 |
| |
| 32–33 | Hebrew something language? Display? Input? what? | |
| 37 | Did you confirm it still fails? | |
| 38–39 | OPTIONS helper | |
| irc/bitchx/pkg-plist | ||
|---|---|---|
| 10 | Necessary because --without-plugins will install the dir empty, and check-plist will complain otherwise. | |
Comment Actions
LGTM, please include all change items in your commit log
| irc/bitchx/Makefile | ||
|---|---|---|
| 20 | LIBS is preferred (for GNU_CONFIGURE) since https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=357486&view=markup Ignore. | |