Page MenuHomeFreeBSD

irc/bitchx: update to 1.2.1
ClosedPublic

Authored by xmj on Jan 28 2015, 1:23 PM.

Details

Reviewers
swills
koobs
Summary

irc/bitchx: update to 1.2.1

  • update to 1.2.1

PR: 195526
DiffRev: placeholder
Submitted by: Chris Petrik <chris@bsdjunk.com>
Approved by: koobs (mentor)

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

xmj updated this revision to Diff 3490.Jan 28 2015, 1:23 PM
xmj retitled this revision from to irc/bitchx: update to 1.2.1.
xmj updated this object.
xmj edited the test plan for this revision. (Show Details)
xmj added reviewers: swills, koobs.
koobs requested changes to this revision.Jan 28 2015, 1:34 PM
koobs edited edge metadata.
koobs added inline comments.
irc/bitchx/Makefile
4

You probably want PORTVERSION here, since DISTVERSION was used in the current version because of the -final suffix

4–5

Remove PORTREVISION after confirming 1.2.1 is > 1.2-final (version comparison using pkg)

If not, you need a PORTEPOCH bump (if 1.2.1 is lower)

9–10

Why do we need ?=

Slave ports?

10–12

Why do we need ?=

Slave ports?

14

Explain perl5 removal?

Your commit log only contains - Update to 1.2.1 but nothing more. Please include all changes/intents

20

Why isn't/can't this be LDFLAGS=?

29

Sort these OPTIONS

32
  • a handful?
  • 'BitchX' is implicit
32–33

Hebrew something language? Display? Input? what?

37

Did you confirm it still fails?

38–39

OPTIONS helper

This revision now requires changes to proceed.Jan 28 2015, 1:34 PM
xmj updated this revision to Diff 3496.Jan 28 2015, 2:52 PM
xmj edited edge metadata.

CRF: Fix lots of issues.

xmj added inline comments.Jan 28 2015, 2:53 PM
irc/bitchx/pkg-plist
10

Necessary because --without-plugins will install the dir empty, and check-plist will complain otherwise.

koobs accepted this revision.Jan 29 2015, 1:04 PM
koobs edited edge metadata.

LGTM, please include all change items in your commit log

irc/bitchx/Makefile
20
This revision is now accepted and ready to land.Jan 29 2015, 1:04 PM
xmj closed this revision.Jan 29 2015, 1:14 PM

Committed revision 378116.