Differential D17091

ClosedPublic
Actions

Authored by woodsb02 on Sep 9 2018, 8:40 AM.

Details

Reviewers

lme

Commits

rP484624: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/

Summary

net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/

Rename files intended for installation to /usr/local/etc/newsyslog.conf.d/
to end with a '.conf' suffix.

Proposed changes to /etc/newsyslog.conf will only include files from the
/usr/local/etc/newsyslog.conf.d/ directory which end with '.conf' and do
not beginning with a '.' character. https://reviews.freebsd.org/D17086

Approved by: lme (maintainer)

Test Plan

poudriere testport -j 12amd64: ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

woodsb02 created this revision.Sep 9 2018, 8:40 AM

Herald added a subscriber: mat. · View Herald TranscriptSep 9 2018, 8:40 AM

Harbormaster completed remote builds in B19475: Diff 47833.Sep 9 2018, 8:40 AM

woodsb02 added a parent revision: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.Sep 9 2018, 8:41 AM

Abandon this change - relocating existing conf files violates POLA.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

Modify port to install file to newsyslog/*.conf
Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).