Differential D17063

depessimize copyinstr_smap
ClosedPublic
Actions

Authored by mjg on Sep 6 2018, 5:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 20 2023, 2:22 AM

	Unknown Object (File)
	Dec 10 2023, 11:17 PM

	Unknown Object (File)
	Sep 6 2023, 9:18 AM

	Unknown Object (File)
	Jul 1 2023, 3:08 AM

	Unknown Object (File)
	May 9 2023, 2:00 AM

	Unknown Object (File)
	May 3 2023, 2:30 AM

	Unknown Object (File)
	Dec 23 2022, 3:34 PM

Subscribers

Details

Reviewers

Commits

rS338508: amd64: depessimize copyinstr_smap

Summary

It was showing up on a name resolution-heavy benchmark (4% as reported by pmcstat, 0.7% after the patch).

The main reason was the slac/clac combo around each byte copy.

The patch reoders lables to remove a common case forward jump (the nosmap routine still suffers it) and englarges the smap-disabled region.

Note the current byte copy loop is still slow and is subject to being optimized later.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Sep 6 2018, 5:05 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2018, 5:05 PM

Harbormaster completed remote builds in B19437: Diff 47757.Sep 6 2018, 5:05 PM

kib added inline comments.Sep 6 2018, 5:54 PM

sys/amd64/amd64/support.S
929 ↗	(On Diff #47757)	This leaks eflags.ac ?

mjg added inline comments.Sep 6 2018, 6:19 PM

sys/amd64/amd64/support.S
929 ↗	(On Diff #47757)	If you mean this gives an exit which leaves smap disabled, then no. There are 2 ways out of stac-ed region: through this label and by falling down to copyinstr_succ. Both have clac. copyinstr_toolong_smap was introduced specifically to clac and and then fallback to previously seen copyinstr_toolong. If that's not what you meant, please elaborate.

kib accepted this revision.Sep 6 2018, 6:42 PM

kib added inline comments.

sys/amd64/amd64/support.S
929 ↗	(On Diff #47757)	Ah, I missed the _smap.

This revision is now accepted and ready to land.Sep 6 2018, 6:42 PM

Closed by commit rS338508: amd64: depessimize copyinstr_smap (authored by mjg). · Explain WhySep 6 2018, 7:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

amd64/

35 lines

Diff 47771

head/sys/amd64/amd64/support.S

Loading...