Page MenuHomeFreeBSD

New port: multimedia/gstreamermm1
Needs ReviewPublic

Authored by woodsb02 on Sep 5 2018, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 7:17 PM
Unknown Object (File)
Dec 20 2023, 8:03 AM
Unknown Object (File)
Nov 10 2023, 1:43 AM
Unknown Object (File)
Nov 8 2023, 1:41 AM
Unknown Object (File)
Oct 7 2023, 12:36 AM
Unknown Object (File)
Jun 12 2023, 6:38 PM
Unknown Object (File)
Jun 7 2023, 11:58 PM
Unknown Object (File)
Jun 3 2023, 1:53 AM
Subscribers

Details

Reviewers
bapt
ehaupt
kwm
riggs
Group Reviewers
multimedia
portmgr
Summary

New port: multimedia/gstreamermm1

C++ wrapper library for the multimedia library GStreamer

This port is for the 1.x branch of GStreamer

Test Plan

poudriere testport -j 12amd64 - all ok
portlint ok

Runtime tested with a local updated version of multimedia/subtitleeditor
which will be committed after this update.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19461
Build 19054: arc lint + arc unit

Event Timeline

multimedia/gstreamermm1/Makefile
16

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

Re-order multimedia/gstreamermm1 Makefile per mat's comment

Also add multimedia/gstreamermm Makefile changes to make consistent
with multimedia/gstreamermm1

woodsb02 added inline comments.
multimedia/gstreamermm1/Makefile
16

Done, but I actually don't think chapter 15 is very clear on where PORTSCOUT goes, and chapter 5 seems to suggest it goes after LICENSES but before DEPENDENCIES.

mat added inline comments.
multimedia/gstreamermm1/Makefile
16

Well, you read the sections in order, and use the first that fits.

It is not in any of the sections that have specific variables set, like the first 7 blocks, it's not a USES/USE_, it's not a standard bsd.port.mk variable, it's not an option, so it goes in The Rest of the Variables.

I cannot find any example saying it goes between licenses and deps.

woodsb02 marked an inline comment as done.

Hi @mat,
As portmgr, can you please approve the changes to Mk/bsd.gstreamer.mk?
Thanks,
Ben

$ grep MAINT Mk/bsd.gstreamer.mk
Gstreamer_Include_MAINTAINER=   multimedia@FreeBSD.org